-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection.createDocument: rename the updateIfExist option #182
Conversation
Codecov Report
@@ Coverage Diff @@
## 4.x #182 +/- ##
==========================================
+ Coverage 99.39% 99.39% +<.01%
==========================================
Files 16 16
Lines 1645 1648 +3
Branches 439 440 +1
==========================================
+ Hits 1635 1638 +3
Misses 10 10
Continue to review full report at Codecov.
|
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "kuzzle-sdk", | |||
"version": "3.2.0", | |||
"version": "3.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad bump, should not be on this branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Description
The
Collection.createDocument
method accepts aupdateIfExist
option.Since this option really replaces the document if it already exists, it is dangerously confusing.
This PR change this option name to
ifExist
and its accepted value to one of these 2 values:error
(default) orreplace
If an invalid value is provided, the method throws.
Solved issue
#181