Collection.createDocument: rename the updateIfExist option #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.x #182 +/- ##
==========================================
+ Coverage 99.39% 99.39% +<.01%
==========================================
Files 16 16
Lines 1645 1648 +3
Branches 439 440 +1
==========================================
+ Hits 1635 1638 +3
Misses 10 10
Continue to review full report at Codecov.
|
xbill82
approved these changes
Feb 15, 2017
dbengsch
approved these changes
Feb 17, 2017
stafyniaksacha
suggested changes
Feb 21, 2017
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "kuzzle-sdk", | |||
| "version": "3.2.0", | |||
| "version": "3.3.0", | |||
There was a problem hiding this comment.
Bad bump, should not be on this branch
benoitvidis
approved these changes
Feb 28, 2017
stafyniaksacha
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Collection.createDocumentmethod accepts aupdateIfExistoption.Since this option really replaces the document if it already exists, it is dangerously confusing.
This PR change this option name to
ifExistand its accepted value to one of these 2 values:error(default) orreplaceIf an invalid value is provided, the method throws.
Solved issue
#181