Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all options given to kuzzle constructor writable #188

Merged
merged 1 commit into from
Mar 2, 2017

Conversation

benoitvidis
Copy link
Contributor

@benoitvidis benoitvidis commented Feb 27, 2017

Description

In some circumstances, we may want to use the same kuzzle object and change its options, for instance to switch to another environment.

This PR allows to update any possible option given to Kuzzle constructor.

Notably, this allows to switch the connection mode back from or to ssl on the current kuzzle instance, without having to create a new object.

Linked issue

kuzzleio/kuzzle-admin-console#154

Linked PRs

kuzzleio/documentation#113

@codecov-io
Copy link

codecov-io commented Feb 27, 2017

Codecov Report

Merging #188 into 4.x will decrease coverage by -0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              4.x     #188      +/-   ##
==========================================
- Coverage   99.45%   99.39%   -0.07%     
==========================================
  Files          16       16              
  Lines        1665     1665              
  Branches      441      441              
==========================================
- Hits         1656     1655       -1     
- Misses          9       10       +1
Impacted Files Coverage Δ
src/Kuzzle.js 99.45% <ø> (-0.19%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5de17a...d749587. Read the comment docs.

@scottinet
Copy link
Contributor

This needs to be documented, with a visible warning explaining to users that changing these parameters won't take effect until an entirely new connection is created.

@dbengsch dbengsch merged commit f47098e into 4.x Mar 2, 2017
@dbengsch dbengsch deleted the ssl-support-for-back-office branch March 2, 2017 16:14
This was referenced Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants