Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize memory storage object #191

Merged
merged 4 commits into from
Mar 13, 2017
Merged

Conversation

scottinet
Copy link
Contributor

Description

Make the MemoryStorage object on par with the newly refactored corresponding controller.

@scottinet scottinet self-assigned this Mar 8, 2017
@codecov-io
Copy link

codecov-io commented Mar 8, 2017

Codecov Report

Merging #191 into 4.x will decrease coverage by -0.04%.
The diff coverage is 98.95%.

@@            Coverage Diff             @@
##              4.x     #191      +/-   ##
==========================================
- Coverage   99.45%   99.41%   -0.04%     
==========================================
  Files          16       16              
  Lines        1648     1709      +61     
  Branches      440      459      +19     
==========================================
+ Hits         1639     1699      +60     
- Misses          9       10       +1
Impacted Files Coverage Δ
src/MemoryStorage.js 99.09% <98.95%> (+1.13%)
src/Kuzzle.js 99.45% <0%> (-0.19%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d544133...9e31b7f. Read the comment docs.

@benoitvidis benoitvidis merged commit 4d2488d into 4.x Mar 13, 2017
@benoitvidis benoitvidis deleted the standardize-memory-storage branch March 13, 2017 15:15
This was referenced Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants