Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ms.hgetall return value interpretation #196

Merged
merged 1 commit into from
Mar 20, 2017
Merged

Fix ms.hgetall return value interpretation #196

merged 1 commit into from
Mar 20, 2017

Conversation

scottinet
Copy link
Contributor

@scottinet scottinet commented Mar 13, 2017

Description

(this PR should not appear in the changelog: it affects only the changes on the MemoryStorage controller in the 4.x SDK version)

The hgetall result was interpreted as an array of, alternatively, key and its associated value, and a mapper function was plugged into this method to ensure a proper JSON object was returned to the client.
But the result of this redis call is already a POJO, so the mapping is unnecessary and causes a SDK crash.

@scottinet scottinet self-assigned this Mar 13, 2017
@scottinet scottinet added the bug label Mar 13, 2017
@codecov-io
Copy link

Codecov Report

Merging #196 into 4.x will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              4.x     #196      +/-   ##
==========================================
+ Coverage   99.36%   99.41%   +0.05%     
==========================================
  Files          16       16              
  Lines        1721     1713       -8     
  Branches      458      457       -1     
==========================================
- Hits         1710     1703       -7     
+ Misses         11       10       -1
Impacted Files Coverage Δ
src/MemoryStorage.js 99.01% <ø> (-0.08%)
src/Kuzzle.js 99.63% <0%> (+0.18%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d2488d...56e7ee7. Read the comment docs.

@jenow jenow merged commit 0e0dd99 into 4.x Mar 20, 2017
@jenow jenow deleted the msbugfix branch March 20, 2017 19:10
This was referenced Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants