Fix ms.zscore return value type #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbengsch
approved these changes
Mar 20, 2017
benoitvidis
approved these changes
Mar 20, 2017
Codecov Report
@@ Coverage Diff @@
## 4.x #198 +/- ##
==========================================
+ Coverage 99.36% 99.41% +0.05%
==========================================
Files 16 16
Lines 1721 1721
Branches 458 458
==========================================
+ Hits 1710 1711 +1
+ Misses 11 10 -1
Continue to review full report at Codecov.
|
jenow
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
ms.zscore()method should return a floating point number, but redis sends a string response, so we need to interpret the result to return the right result type.