Adds a new replaceUser method to Security #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 5.x #208 +/- ##
==========================================
+ Coverage 99.41% 99.42% +<.01%
==========================================
Files 16 16
Lines 1718 1733 +15
Branches 458 465 +7
==========================================
+ Hits 1708 1723 +15
Misses 10 10
Continue to review full report at Codecov.
|
stafyniaksacha
suggested changes
Apr 24, 2017
src/security/Security.js
Outdated
| action = options.replaceIfExist ? 'createOrReplaceUser' : 'createUser'; | ||
| if (options && options.replaceIfExist) { | ||
| self.fetchUser(id, function (fetchError, fetchResult) { | ||
| if (fetchResult instanceof User && options && options.replaceIfExist === true) { |
There was a problem hiding this comment.
We can reject the query here if fetchUser return a user and options.replaceIfExist !== true without querying kuzzle
There was a problem hiding this comment.
Indeed, PR updated
samniisan
force-pushed
the
21-replace-user
branch
from
934fe3e
to
c8ec494
Compare
benoitvidis
approved these changes
Apr 24, 2017
dbengsch
approved these changes
Apr 25, 2017
samniisan
force-pushed
the
21-replace-user
branch
from
c8ec494
to
c7c2554
Compare
stafyniaksacha
approved these changes
Apr 26, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to https://github.com/kuzzleio/kuzzle-sdk/issues/21