-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize event emitters implementation #210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…internal components (Kuzzle as well as websocket network wrapper for now)
+ implement the same methods in browser mode
Codecov Report
@@ Coverage Diff @@
## 5.x #210 +/- ##
=========================================
- Coverage 99.36% 95.06% -4.3%
=========================================
Files 16 17 +1
Lines 1733 1885 +152
Branches 465 511 +46
=========================================
+ Hits 1722 1792 +70
- Misses 11 93 +82
Continue to review full report at Codecov.
|
See discussion on #197 that were approved, but merged on the wrong branch |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main
Kuzzle
SDK prototype and websocket wrapper implementation both used their own event listeners.Now, both Kuzzle and websocket wrapper inherits from Node build-in
EventEmitter
class (https://nodejs.org/api/events.html), with a polyfilled implementation for browser.Breaking Changes
method
addListener
no longer returns an ID, to be compliant with NodeJS implementation ( https://nodejs.org/api/events.html#events_emitter_on_eventname_listener )It now returns the Emitter object itself, so that it can be chained.
For each event, the listener callback function is used as the key in listeners list
Documentation
kuzzleio/documentation#172