-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added all new credential related routes #217
Conversation
# Conflicts: # src/Kuzzle.js
Codecov Report
@@ Coverage Diff @@
## 4.x #217 +/- ##
======================================
Coverage ? 99.45%
======================================
Files ? 16
Lines ? 1845
Branches ? 529
======================================
Hits ? 1835
Misses ? 10
Partials ? 0
Continue to review full report at Codecov.
|
* @param cb | ||
* @returns {Security} | ||
*/ | ||
Security.prototype.createCredentials = function (strategy, kuid, credentials, options, cb) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if !strategy
?
* @param cb | ||
* @returns {Security} | ||
*/ | ||
Security.prototype.deleteCredentials = function (strategy, kuid, options, cb) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if !strategy
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This applies to all the following methods that accept strategy
as the first argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then kuzzle wil answer an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok then we assume that we leave the responsibility to Kuzzle. Approving.
Creation of new actions in auth controller:
Creation of new actions in security controller: