Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login reshape #218

Merged
merged 1 commit into from
May 18, 2017
Merged

Login reshape #218

merged 1 commit into from
May 18, 2017

Conversation

xbill82
Copy link
Contributor

@xbill82 xbill82 commented May 15, 2017

⚠️ This PR depends on kuzzleio/kuzzle#840

Description

Reshapes the login call according to the PR kuzzleio/kuzzle#840

  • The SDK now throws if no strategy is specified in the login call.

@codecov-io
Copy link

codecov-io commented May 15, 2017

Codecov Report

Merging #218 into 5.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              5.x     #218      +/-   ##
==========================================
+ Coverage   98.48%   98.48%   +<.01%     
==========================================
  Files          17       17              
  Lines        1778     1780       +2     
  Branches      476      477       +1     
==========================================
+ Hits         1751     1753       +2     
  Misses         27       27
Impacted Files Coverage Δ
src/Kuzzle.js 98.64% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44845db...dfea857. Read the comment docs.

@xbill82 xbill82 merged commit cd79766 into 5.x May 18, 2017
@xbill82 xbill82 deleted the 831-login-reshape branch May 18, 2017 10:14
This was referenced May 24, 2017
@scottinet scottinet mentioned this pull request Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants