Network error handling #226

stafyniaksacha · 2017-06-01T15:10:19Z

Bugfixes

SocketIO: handle network errors (like we do in Websocket protocol wrapper)
Websocket: arguments can differs from NodeJS and Browsers
Auto resubscribe when a reconnection occurs after a network error

codecov-io · 2017-06-07T09:42:09Z

Codecov Report

Merging #226 into 5.x will increase coverage by 0.3%.
The diff coverage is 98.59%.

@@            Coverage Diff            @@
##              5.x     #226     +/-   ##
=========================================
+ Coverage   98.24%   98.54%   +0.3%     
=========================================
  Files          17       17             
  Lines        2050     2408    +358     
  Branches      590      714    +124     
=========================================
+ Hits         2014     2373    +359     
+ Misses         36       35      -1

Impacted Files	Coverage Δ
src/Kuzzle.js	`98.94% <100%> (+0.19%)`	⬆️
src/Room.js	`100% <100%> (ø)`	⬆️
src/networkWrapper/wrappers/socketio.js	`100% <100%> (ø)`	⬆️
src/networkWrapper/wrappers/websocket.js	`98.7% <95.45%> (-1.3%)`	⬇️
src/security/User.js	`98.78% <0%> (+0.01%)`	⬆️
src/MemoryStorage.js	`99.41% <0%> (+0.39%)`	⬆️
src/security/Security.js	`98.25% <0%> (+0.52%)`	⬆️
src/Collection.js	`97.94% <0%> (+1.08%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec13b7f...30064fe. Read the comment docs.

ballinette · 2017-06-07T14:12:47Z

missing description of what is the issue this PR fixes ?

benoitvidis

Can you provide some information about this PR (context, issue, what is the problem and what it solves?)

benoitvidis · 2017-06-07T14:10:51Z

src/networkWrapper/wrappers/socketio.js

    this.socket = window.io((this.ssl ? 'https://' : 'http://') + this.host + ':' + this.port, {
      reconnection: autoReconnect,
      reconnectionDelay: reconnectionDelay,
      forceNew: true
    });
+
+    this.socket.on('connect', function() {
+      if (self.wasConnected) {


According to socket.io documentation, connect event is fired "upon a connection including a successful reconnection".
If this is the case, don't we have a double trigger with the on('reconnect',..) one?

Nope, this is different cases:

reconnection on connect event is used when proxy close connection

reconnection on reconnect event is used when socket hang out and come back again via socket io reconnection logic

Well, I see that you intend to use them differently but this is not what the doc says. connect is fired each time a connection is made, including socket.io reconnections.

Ok, so I removed reconnect listener

benoitvidis · 2017-06-07T14:12:47Z

src/networkWrapper/wrappers/socketio.js

+          self.retrying = false;
+          self.connect(autoReconnect, reconnectionDelay);
+        }, reconnectionDelay);
+      }


isn't this part supposed to be natively handled by socket.io reconnect options?

I don't know why but reconnection from socketio does not work... (love socketio <3)

Hum.. If this is the case, shouldn't we then just not use it at all?
If it happens to work as expected, I still see an double trigger issue btw the connect and reconnect handlers (latest never being fired).

stafyniaksacha · 2017-06-07T15:16:09Z

@ballinette @benoitvidis sorry for the description, I haven't saved it ^^

ballinette · 2017-06-08T08:36:45Z

src/Room.js

-  subscribeQuery = self.kuzzle.addHeaders(subscribeQuery, this.headers);
+  subscribeQuery = self.kuzzle.addHeaders(subscribeQuery, self.headers);
+
+  networkListener = function() {


I don't like this behaviour (too many "addListener" and "removeListener").

Better just add following lines into src/Kuzzle.js (at line 365) :

self.network.onConnectError(function (error) { // (...) disableAllSubscriptions.call(self); // (...) }); function disableAllSubscriptions() { var self = this; Object.keys(self.subscriptions).forEach(function (roomId) { Object.keys(self.subscriptions[roomId]).forEach(function (subscriptionId) { var subscription = self.subscriptions[roomId][subscriptionId]; subscription.subscribing = false; }); }); }

It should work, but without a complex listener management.

Work like a charm !

…io_disconnect

benoitvidis · 2017-06-08T10:14:13Z

src/networkWrapper/wrappers/socketio.js

    this.socket = window.io((this.ssl ? 'https://' : 'http://') + this.host + ':' + this.port, {
      reconnection: autoReconnect,
      reconnectionDelay: reconnectionDelay,
      forceNew: true
    });
+
+    this.socket.on('connect', function() {
+      if (self.wasConnected) {


Well, I see that you intend to use them differently but this is not what the doc says. connect is fired each time a connection is made, including socket.io reconnections.

benoitvidis · 2017-06-08T10:14:23Z

src/networkWrapper/wrappers/socketio.js

+          self.retrying = false;
+          self.connect(autoReconnect, reconnectionDelay);
+        }, reconnectionDelay);
+      }


Hum.. If this is the case, shouldn't we then just not use it at all?
If it happens to work as expected, I still see an double trigger issue btw the connect and reconnect handlers (latest never being fired).

STAFYNIAK Sacha added 2 commits June 1, 2017 16:34

handle proxy force disconnection + error handling

7cddb0b

Merge remote-tracking branch 'origin/5.x' into network-error-handling

d423458

stafyniaksacha added wip changelog:bug-fixes and removed wip labels Jun 1, 2017

rewrite socketio tests

321211f

benoitvidis suggested changes Jun 7, 2017

View reviewed changes

stafyniaksacha changed the title ~~Network error handling~~ Disconnect client when no backend left Jun 7, 2017

stafyniaksacha changed the title ~~Disconnect client when no backend left~~ Network error handling Jun 7, 2017

ballinette suggested changes Jun 8, 2017

View reviewed changes

STAFYNIAK Sacha added 3 commits June 8, 2017 10:39

upgrade WS to 3.0.0 + rename kuzzle_proxy_disconnect to kuzzle_socket…

7f004b6

…io_disconnect

tests

6f96f6b

implement @ballinette remark

ab465ee

benoitvidis suggested changes Jun 8, 2017

View reviewed changes

simplify socketio network error managment

33efbae

ballinette approved these changes Jun 8, 2017

View reviewed changes

remove useless reconnection listener (socketio)

a255ace

benoitvidis approved these changes Jun 8, 2017

View reviewed changes

add port to connection error message

30064fe

xbill82 approved these changes Jun 8, 2017

View reviewed changes

xbill82 merged commit d63b2cb into 5.x Jun 8, 2017

xbill82 deleted the network-error-handling branch June 8, 2017 15:58

scottinet mentioned this pull request Jun 20, 2017

Release: 5.0.4 #235

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Network error handling #226

Network error handling #226

stafyniaksacha commented Jun 1, 2017 •

edited

Loading

codecov-io commented Jun 7, 2017 •

edited

Loading

ballinette commented Jun 7, 2017

benoitvidis left a comment

benoitvidis Jun 7, 2017

stafyniaksacha Jun 7, 2017

benoitvidis Jun 8, 2017

stafyniaksacha Jun 8, 2017

benoitvidis Jun 7, 2017

stafyniaksacha Jun 7, 2017

benoitvidis Jun 8, 2017

stafyniaksacha commented Jun 7, 2017 •

edited

Loading

ballinette Jun 8, 2017

stafyniaksacha Jun 8, 2017

benoitvidis Jun 8, 2017

benoitvidis Jun 8, 2017

Network error handling #226

Network error handling #226

Conversation

stafyniaksacha commented Jun 1, 2017 • edited Loading

Bugfixes

codecov-io commented Jun 7, 2017 • edited Loading

Codecov Report

ballinette commented Jun 7, 2017

benoitvidis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stafyniaksacha commented Jun 7, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stafyniaksacha commented Jun 1, 2017 •

edited

Loading

codecov-io commented Jun 7, 2017 •

edited

Loading

stafyniaksacha commented Jun 7, 2017 •

edited

Loading