Update MemoryStorage.*scan return value format #227
Conversation
Codecov Report
@@ Coverage Diff @@
## 5.x #227 +/- ##
==========================================
+ Coverage 98.24% 98.24% +<.01%
==========================================
Files 17 17
Lines 2050 2052 +2
Branches 590 590
==========================================
+ Hits 2014 2016 +2
Misses 36 36
Continue to review full report at Codecov.
|
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "kuzzle-sdk", | |||
| "version": "5.0.1", | |||
| "version": "5.0.2", | |||
There was a problem hiding this comment.
I thought that package.json should be updated by the release PR, not there ?
There was a problem hiding this comment.
Yes, but as I stated last week, I plan to merge this PR directly on master once it is merged on 5.x, and to rewrite the tag to make the 5.x version of this SDK start at 5.0.2 instead of 5.0.0.
So I won't use the release tool and I want to merge this PR as-is, without modifying it before reaching master.
The idea is to avoid major versions jumps, as the 5.x version has to be released before Kuzzle RC10. It is currently unusable anyway, until RC10 is released.
Description
Following the work done in kuzzleio/documentation#281, the returned values of
MemoryStorage.*scanmethods has been changed.This PR updates the SDK to make it match the new return value format for these methods.
Note: this will trigger a patch version update on this SDK (5.0.2), as the published 5.x version is not usable until Kuzzle RC10 is out