Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fetchAllDocuments method #228

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

benoitvidis
Copy link
Contributor

This PR removes the fetchAllDocuments method from the SDK, which can be better replaced by a search + fetchNext call (documentation to come).

Copy link
Contributor

@samniisan samniisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me after checking the Travis error in offlineQueue.test.js

@benoitvidis benoitvidis force-pushed the ref-23-remove-fetchalldocuments branch from bde39e2 to e76204c Compare June 7, 2017 12:14
@codecov-io
Copy link

Codecov Report

Merging #228 into 5.x will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              5.x     #228      +/-   ##
==========================================
+ Coverage   98.24%   98.51%   +0.27%     
==========================================
  Files          17       17              
  Lines        2050     2027      -23     
  Branches      590      583       -7     
==========================================
- Hits         2014     1997      -17     
+ Misses         36       30       -6
Impacted Files Coverage Δ
src/Collection.js 98.64% <ø> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec13b7f...e76204c. Read the comment docs.

@stafyniaksacha stafyniaksacha merged commit 89503a6 into 5.x Jun 7, 2017
@stafyniaksacha stafyniaksacha deleted the ref-23-remove-fetchalldocuments branch June 7, 2017 13:41
@scottinet scottinet mentioned this pull request Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants