-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specification CRUDL routes #231
Conversation
Codecov Report
@@ Coverage Diff @@
## 5.x #231 +/- ##
==========================================
+ Coverage 98.56% 98.72% +0.16%
==========================================
Files 17 17
Lines 2085 2512 +427
Branches 595 762 +167
==========================================
+ Hits 2055 2480 +425
- Misses 30 32 +2
Continue to review full report at Codecov.
|
* @param {object} [options] - Optional parameters | ||
* @param {responseCallback} cb - Handles the query response | ||
*/ | ||
Collection.prototype.scrollSpecifications = function (scrollId, options, cb) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other scroll methods return a KuzzleSearchResult object, shouldn't this one do the same?
* @param {object} [options] - Optional parameters | ||
* @param {responseCallback} cb - Handles the query response | ||
*/ | ||
Collection.prototype.searchSpecifications = function (filters, options, cb) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other search methods return a KuzzleSearchResult object, shouldn't this one do the same?
@scottinet Just updated this PR according to your comments |
6410513
to
2d099f1
Compare
fix kuzzleio/kuzzle-sdk#3
Introduces