Login: move "expiresIn" option from request.body to request root attribute #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 5.x #238 +/- ##
==========================================
- Coverage 98.46% 98.38% -0.08%
==========================================
Files 17 17
Lines 2143 2172 +29
Branches 609 616 +7
==========================================
+ Hits 2110 2137 +27
- Misses 33 35 +2
Continue to review full report at Codecov.
|
scottinet
approved these changes
Jul 4, 2017
samniisan
approved these changes
Jul 5, 2017
dbengsch
reviewed
Jul 6, 2017
src/Kuzzle.js
Outdated
| @@ -523,11 +526,11 @@ Kuzzle.prototype.login = function (strategy) { | |||
|
|
|||
| if (typeof credentials === 'object') { | |||
| Object.keys(credentials).forEach(function (key) { | |||
There was a problem hiding this comment.
The body could just be set to credentials instead of copying it property by property
stafyniaksacha
approved these changes
Jul 7, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://github.com/kuzzleio/kuzzle-sdk/issues/39