Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed User Notification response format #240

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Conversation

samniisan
Copy link
Contributor

Fixes in the way the JS SDK handles the User Notification response.

See changes in the documentation PR: kuzzleio/documentation#330

@samniisan samniisan self-assigned this Jul 5, 2017
@codecov-io
Copy link

codecov-io commented Jul 5, 2017

Codecov Report

Merging #240 into 5.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              5.x     #240      +/-   ##
==========================================
- Coverage   98.46%   98.45%   -0.01%     
==========================================
  Files          17       17              
  Lines        2143     2140       -3     
  Branches      609      608       -1     
==========================================
- Hits         2110     2107       -3     
  Misses         33       33
Impacted Files Coverage Δ
src/Room.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ecab74...60ae5f4. Read the comment docs.

@scottinet scottinet merged commit 0b72e8b into 5.x Jul 7, 2017
@scottinet scottinet deleted the user-notification-format branch July 7, 2017 13:03
@stafyniaksacha stafyniaksacha mentioned this pull request Jul 19, 2017
@scottinet scottinet mentioned this pull request Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants