Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: an other way to make typescript happy with imagetools url import #23

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Conversation

SrGeneroso
Copy link
Contributor

@SrGeneroso SrGeneroso commented Sep 15, 2022

I've give a deep search into the imagetools // @ts-ignore thing in the config/site.ts

I've found a workaround in this post: JonasKruckenberg/imagetools#160 (comment)

I have barely a little experience with typescript, so please test it for yourself.

Hope it helps.

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022

⚠️ No Changeset found

Latest commit: f743863

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kwchang0831 kwchang0831 changed the title Fix imagetools types Fix: an other way to make typescript happy with imagetools url import Sep 15, 2022
@kwchang0831 kwchang0831 added the not-bug Not a Bug label Sep 15, 2022
@kwchang0831
Copy link
Owner

I have read through JonasKruckenberg/imagetools#160 (comment).

I will leave it open for now since it is not critically affecting functionality.
I will look into it more later when I get other more important stuff done.

@kwchang0831 kwchang0831 merged commit 0c3b067 into kwchang0831:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-bug Not a Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants