Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Go metrics in service-catalog controller-manager #1043

Closed
piotrmiskiewicz opened this issue Oct 1, 2018 · 1 comment
Closed

Enable Go metrics in service-catalog controller-manager #1043

piotrmiskiewicz opened this issue Oct 1, 2018 · 1 comment
Assignees
Labels
area/monitoring Issues or PRs related to the monitoring module (deprecated) area/service-management Issues or PRs related to service management kind/feature Categorizes issue or PR as related to a new feature.

Comments

@piotrmiskiewicz
Copy link
Member

AC:
Grafana dashboard with Go metrics for service-catalog controller-manager.

Hint:
see 'controllerManager.enablePrometheusScrape' value

@piotrmiskiewicz piotrmiskiewicz added this to the Sprint_Gopher_2 milestone Oct 1, 2018
@piotrmiskiewicz piotrmiskiewicz added area/monitoring Issues or PRs related to the monitoring module (deprecated) area/service-management Issues or PRs related to service management kind/feature Categorizes issue or PR as related to a new feature. labels Oct 1, 2018
@PK85 PK85 modified the milestones: Sprint_Gopher_2, Backlog_Gopher Oct 2, 2018
@PK85 PK85 modified the milestones: Backlog_Gopher, Sprint_Gopher_3 Oct 16, 2018
@mszostok mszostok self-assigned this Oct 18, 2018
@mszostok
Copy link
Contributor

mszostok commented Oct 23, 2018

Please see this PR to check introduced modifications.

Overview of this task

The Service Catalog Manager expose only the business metrics (they are always available - hardcoded in source code). The are three types of metrics:

  • BrokerServiceClassCount - Number of services classes by Broker.
  • BrokerServicePlanCount - Number of services classes by Broker.
  • OSBRequestCount - Cumulative number of HTTP requests from the OSB Client to the specified Service Broker grouped by broker name, broker method, and response status.

source: https://github.com/kubernetes-incubator/service-catalog/blob/v0.1.34/pkg/metrics/metrics.go#L77-L83

this functionality was introduced by this PR: https://github.com/kubernetes-incubator/service-catalog/pull/1608/files

The controllerManager.enablePrometheusScrape flag in values.yaml file from ServiceCatalog Helm Chart refers only to the Prometheus configuration. Setting it to true will direct Prometheus to automatically scrape custom metrics exposed from Service Catalog because it's looking for pods with the prometheus.io/scrape annotation. But we are using the Prometheus operator and

The annotation is not supported by the operator. ServiceMonitors should be
used instead. The annotation is very limited by its nature and there's no
feasible way to support anything beyond "scrape on" and a single port.

source: prometheus-operator/kube-prometheus#16 (comment)

because of that, we are using the ServiceMonitor.

In this task I've added only new graphs for the business metrics for Controller manager. If we want to have also the Go metrics or add more business metrics then we need to contribute to the ServiceCatalog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Issues or PRs related to the monitoring module (deprecated) area/service-management Issues or PRs related to service management kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants