Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support include directive #32 #43

Merged
merged 34 commits into from
Aug 7, 2023
Merged

support include directive #32 #43

merged 34 commits into from
Aug 7, 2023

Conversation

kyu08
Copy link
Owner

@kyu08 kyu08 commented Jul 27, 2023 •
edited
Loading

close #32, close #13

  • Addressed relative path issue
  • Added unit tests
  • Checked for functions that can be refactored into methods
  • Verified appropriate dependencies
  • Evaluated naming and organization of the 'file' module
  • Assessed module boundaries
  • Ensured appropriate naming
  • Reviewed module's public interface: Link

@kyu08 kyu08 self-assigned this Jul 27, 2023
@kyu08 kyu08 force-pushed the feat_32 branch 2 times, most recently from 8ec1467 to 18220e0 Compare July 27, 2023 17:04
@kyu08 kyu08 changed the title Feat 32 support *.mk not only Makefile #32 Jul 27, 2023
@kyu08 kyu08 force-pushed the feat_32 branch 4 times, most recently from 86a6387 to 831ee09 Compare July 29, 2023 12:47
@kyu08 kyu08 changed the title support *.mk not only Makefile #32 support including other file #32 Jul 29, 2023
@kyu08 kyu08 changed the title support including other file #32 support including files #32 Jul 29, 2023
@kyu08 kyu08 force-pushed the feat_32 branch 2 times, most recently from 2b23429 to 8e18ed9 Compare July 30, 2023 16:26
@kyu08 kyu08 force-pushed the feat_32 branch 2 times, most recently from 2dcaad1 to 464b06b Compare July 31, 2023 17:02
@kyu08 kyu08 changed the title support including files #32 support include directive #32 Aug 1, 2023
kyu08
kyu08 commented Aug 7, 2023
View reviewed changes
src/parser/makefile.rs Outdated Show resolved Hide resolved
kyu08
kyu08 commented Aug 7, 2023
View reviewed changes
src/file/file.rs Outdated Show resolved Hide resolved
kyu08
kyu08 commented Aug 7, 2023
View reviewed changes
src/file/file.rs Outdated Show resolved Hide resolved
@kyu08 kyu08 merged commit 977418c into main Aug 7, 2023
2 checks passed
@kyu08 kyu08 deleted the feat_32 branch August 7, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kyu08 kyu08

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support include directive reconsider module structure
1 participant
@kyu08