Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service selector variable #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

shyamjos
Copy link

If the .Values.name is defined and the user passes release name via helm cli , then we should set selector as {{ include "scanner.fullname" . }} otherwise service will become inaccessible

If the .Values.name is defined and the user passes release name via helm cli , then we should set selector as `{{ include "scanner.fullname" . }}` otherwise service will become inaccessible
@CLAassistant
Copy link

CLAassistant commented Sep 28, 2022

CLA assistant check
All committers have signed the CLA.

Copy link

@joebowbeer joebowbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants