Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying lacework-agent values #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soudaburger
Copy link

The original values.yaml is a bit difficult to parse and missing at least one example (when laceworkConfig.accessToken is a map, not a string). It sorts everything alphabetically and adds specific key references so that when you're traversing the YAML file, you can still understand where each key belongs.

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2022

CLA assistant check
All committers have signed the CLA.

@cirego
Copy link
Contributor

cirego commented Jul 6, 2022

Hi @soudaburger, sorry for the delayed response. Thank you for taking the time to put together this contribution!

If you're not aware, this repository is downstream from an internal repository and is updated when we release new versions of the agent. I'm going to see what I can do to incorporate these changes into our upstream repo.

Looking at this PR, there may be another challenge adopting this. We use the yq tool to automate inserting the correct agent version into our Helm Chart and it sometimes decides to order fields / remove comments. Hopefully I can find the right incantation to make it work nicely with your improvements!

@soudaburger
Copy link
Author

Anything you can do to get this to where it needs to go is fine by me. Appreciate the assist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants