fix(codeBlock): backspace key deletes code block when all code is sel…

…ected
lakejs · Jul 15, 2024 · d4c24bf · d4c24bf
1 parent 2af8052
commit d4c24bf
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/src/plugins/backspace-key.ts b/src/plugins/backspace-key.ts
@@ -67,7 +67,10 @@ export default (editor: Editor) => {
       const boxNode = range.commonAncestor.closest('lake-box');
       const box = getBox(boxNode);
       const boxValue = box.value;
-      if (box.name === 'codeBlock' && (boxValue.code === undefined || boxValue.code === '')) {
+      if (
+        range.isCollapsed && box.name === 'codeBlock' &&
+        (boxValue.code === undefined || boxValue.code === '')
+      ) {
         event.preventDefault();
         editor.selection.removeBox(box);
         editor.history.save();

diff --git a/tests/plugins/backspace-key.test.ts b/tests/plugins/backspace-key.test.ts
@@ -856,7 +856,7 @@ describe('plugins / backspace-key', () => {
     );
   });
 
-  it('should remove empty code block', () => {
+  it('should remove empty code block when selected range is collapsed', () => {
     const content = `
     <p>foo</p>
     <lake-box type="block" name="codeBlock" focus="center"></lake-box>
@@ -877,4 +877,25 @@ describe('plugins / backspace-key', () => {
     );
   });
 
+  it('should not remove empty code block when selected range is expanded', () => {
+    const content = `
+    <p>foo</p>
+    <lake-box type="block" name="codeBlock" focus="center"></lake-box>
+    `;
+    const output = `
+    <p>foo</p>
+    <lake-box type="block" name="codeBlock" focus="center"></lake-box>
+    `;
+    testPlugin(
+      content,
+      output,
+      editor => {
+        const boxNode = editor.container.find('lake-box');
+        boxNode.find('.cm-line').text('foo');
+        editor.selection.range.selectNodeContents(boxNode.find('.cm-line'));
+        editor.keystroke.keydown('backspace');
+      },
+    );
+  });
+
 });