add swap() tests for Pool 5 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubzn
approved these changes
Dec 1, 2023
dpinones
approved these changes
Dec 1, 2023
rcatalan98
requested changes
Dec 1, 2023
| let pool_case = POOL_CASES()[5]; | ||
| let (success_swap_cases, panic_swap_cases) = SWAP_CASES_POOL_5(); | ||
| let expected_cases = | ||
| SWAP_EXPECTED_RESULTS_POOL_5(); //get random case, is never executed |
There was a problem hiding this comment.
What's the meaning of this?
//get random case, is never executed
There was a problem hiding this comment.
it was a comment that is no longer necessary, it has now been removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the swap tests corresponding to the Pool 5, resolving issue #166
Before resolving this PR, the original swap tests PR #152 should be resolved.