Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add swap() tests for Pool 6 #177

Merged
merged 21 commits into from
Dec 11, 2023
Merged

add swap() tests for Pool 6 #177

merged 21 commits into from
Dec 11, 2023

Conversation

uri-99
Copy link
Collaborator

@uri-99 uri-99 commented Nov 9, 2023

This PR adds the swap tests corresponding to the Pool 6, resolving issue #167

Before resolving this PR, the original swap tests #152 should be resolved.

@dubzn dubzn changed the base branch from main to test/swap December 1, 2023 18:08
@uri-99 uri-99 marked this pull request as ready for review December 1, 2023 18:46
crates/yas_core/src/tests/utils/pool_6.cairo Outdated Show resolved Hide resolved
crates/yas_core/src/tests/utils/pool_6.cairo Outdated Show resolved Hide resolved
crates/yas_core/src/tests/utils/pool_6.cairo Outdated Show resolved Hide resolved
crates/yas_core/src/tests/utils/pool_6.cairo Outdated Show resolved Hide resolved
crates/yas_core/src/tests/utils/pool_6.cairo Outdated Show resolved Hide resolved
crates/yas_core/src/tests/utils/pool_6.cairo Outdated Show resolved Hide resolved
crates/yas_core/src/tests/utils/pool_6.cairo Show resolved Hide resolved
@uri-99 uri-99 requested a review from dubzn December 5, 2023 20:19
Copy link
Collaborator

@rcatalan98 rcatalan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Please address @dubzn comments

@dubzn dubzn merged commit e67656e into test/swap Dec 11, 2023
3 checks passed
@dubzn dubzn deleted the pool-6 branch December 11, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants