Add swap() tests for Pool 2 #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uri-99
approved these changes
Nov 29, 2023
rcatalan98
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Hey, great work! I just see two things that look like they were added somewhere because I don't see it in the file changes.
When you run the tests there is a "case" printed constantly.
There is a test that for some reason it takes too long to finish? Do you know why?
Never mind we are going to address this after all the debugging "hacks" are no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the swap tests corresponding to the Pool 2, resolving issue #163