add swap() tests for Pool 9 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubzn
suggested changes
Dec 6, 2023
| pool_case, | ||
| array![*expected_cases[PANIC_CASE]], | ||
| array![*panic_swap_cases[PANIC_CASE]], | ||
| PRECISION |
There was a problem hiding this comment.
Suggested change
| PRECISION | |
| Zeroable::zero() |
There was a problem hiding this comment.
Done, i will push the same comment on test/swap for the already merged pools
Comment on lines
+1823
to
+1824
| amount_to_swap = | ||
| IntegerTrait::<i256>::new(*swap_case.amount_specified.mag, true); |
There was a problem hiding this comment.
why this change is here? what does mean?
There was a problem hiding this comment.
This answer is really important because this function affects the whole test suite
rcatalan98
approved these changes
Dec 6, 2023
Comment on lines
+1823
to
+1824
| amount_to_swap = | ||
| IntegerTrait::<i256>::new(*swap_case.amount_specified.mag, true); |
There was a problem hiding this comment.
This answer is really important because this function affects the whole test suite
added 2 commits
December 6, 2023 17:11
dubzn
approved these changes
Dec 7, 2023
dpinones
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #170
This PR shouldn't be merged before #194 , as it has its implementation. This PR won't pass CI tests without this.