Refactor - Add NaN to expected values (Pool 9)
#201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could work but the long term solution would be to create an Enum for the execution price and have some sort of definitions that wraps |
I like this approach, though it will require a refactor in the expected_values structure, having to generate all of them again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like Uniswap V3 in the case of Pool 9 (it also applies to Pool 8 but is done in the corresponding PR), when the deltas resulting from a transaction are 0, and then you want to calculate the
execution_price, this results inNaN.In this PR, that change is applied to provide more clarity and be more faithful to the results of Uniswap tests.