Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC]: Extension of use for this component #34

Open
froschdesign opened this issue Oct 13, 2021 · 1 comment
Open

[RFC]: Extension of use for this component #34

froschdesign opened this issue Oct 13, 2021 · 1 comment
Assignees
Labels
RFC Request for Comment; proposal for major new feature or changes.

Comments

@froschdesign
Copy link
Member

RFC

Q A
Proposed Version(s) >=0.1.0
BC Break? No

Goal

Open the component, for wider use.

Background

At the moment, the use of this component is limited to the migration of code for compatibility with version 4 of laminas-servicemanager.

Considerations

The name of the component is laminas-servicemanager-migration and this can also include adding or removing support for laminas-servicemanager.

Proposal(s)

As an example, a rewrite of factories​ from:

class MyObjectFactory implements FactoryInterface
{
   ​public function __invoke(Interop\Container\ContainerInterface $container, $requestedName, array $options = null)
   ​{
       ​$dependency = $container->get(stdClass::class);
       ​return new MyObject($dependency);
   ​}
}

to:

class MyObjectFactory
{
   ​public function __invoke(Psr\Container\ContainerInterface $container)
   ​{
       ​$dependency = $container->get(stdClass::class);
       ​return new MyObject($dependency);
   ​}
}

and vice versa.

@froschdesign froschdesign added the RFC Request for Comment; proposal for major new feature or changes. label Oct 13, 2021
@samsonasik
Copy link
Member

that's seems possible with create custom rector rule for this specific use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request for Comment; proposal for major new feature or changes.
Projects
None yet
Development

No branches or pull requests

2 participants