-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rector] Add ImplementsFactoryInterfaceToPsrFactoryRector #35
Conversation
Is there a way to have a |
I will add test for it under Fixture for before -> after like this https://github.com/laminas/laminas-servicemanager-migration/blob/0.1.x/test/Rector/RenameClassRector/Fixture/factory_invoke_typehint.php.inc |
bfc651f
to
76d9020
Compare
...AbstractFactoryToPsrFactoryRector/Fixture/implements_root_abstract_factory_interface.php.inc
Outdated
Show resolved
Hide resolved
862aa4b
to
2a69bc0
Compare
...plementsFactoryInterfaceToPsrFactoryRector/Fixture/implements_root_factory_interface.php.inc
Show resolved
Hide resolved
...plementsFactoryInterfaceToPsrFactoryRector/Fixture/implements_root_factory_interface.php.inc
Show resolved
Hide resolved
71390be
to
ed801de
Compare
@froschdesign I added functionality to remove use |
b5f5cac
to
8251d97
Compare
...ureAutoImportRenameUse/implements_root_factory_interface_call_other_type_hint_method.php.inc
Outdated
Show resolved
Hide resolved
70448a7
to
610a1b6
Compare
5b7a773
to
49dc7c4
Compare
@froschdesign I've added documentation |
All green 🎉 |
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
…ontainer.md Co-authored-by: Frank Brückner <[email protected]> Signed-off-by: Abdul Malik Ikhsan <[email protected]>
…ontainer.md Co-authored-by: Frank Brückner <[email protected]> Signed-off-by: Abdul Malik Ikhsan <[email protected]>
…ontainer.md Co-authored-by: Frank Brückner <[email protected]> Signed-off-by: Abdul Malik Ikhsan <[email protected]>
…ontainer.md Co-authored-by: Frank Brückner <[email protected]> Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
…ontainer.md Co-authored-by: Frank Brückner <[email protected]> Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
…ontainer.md Co-authored-by: Frank Brückner <[email protected]> Signed-off-by: Abdul Malik Ikhsan <[email protected]>
16129e3
to
cffa349
Compare
Thank you @froschdesign @Ocramius for the review. I am merging it and will create 0.2.0 release for it |
Then we can see if #32 has also been solved. |
Description
Adding
ImplementsFactoryInterfaceToPsrFactoryRector
to change class implements FactoryInterface with has__invoke()
method to Psr Factory.Part of #34
Todo: