Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add about Rector documentation #110

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Add about Rector documentation #110

merged 3 commits into from
Jan 20, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jan 14, 2023

Signed-off-by: Abdul Malik Ikhsan [email protected]

Q A
Documentation yes

Description

@froschdesign this is copied from the website https://getrector.org/about

Ref to fill part of #70

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
docs/book/v1/intro.md Outdated Show resolved Hide resolved
@froschdesign froschdesign linked an issue Jan 16, 2023 that may be closed by this pull request
4 tasks
Co-authored-by: Frank Brückner <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@samsonasik
Copy link
Member Author

@froschdesign updated 👍

docs/book/v1/intro.md Outdated Show resolved Hide resolved
Co-authored-by: Frank Brückner <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An important information is missing in the introduction:

How can it help with laminas-servicemanager?

@samsonasik
Copy link
Member Author

Yes, that still missing, should probably separate PR for that, per PR description, it only part of #70

@samsonasik
Copy link
Member Author

Let's merge so we have progress

@samsonasik samsonasik merged commit f45028b into 1.9.x Jan 20, 2023
@samsonasik samsonasik deleted the add-about-rector branch January 20, 2023 21:44
@samsonasik
Copy link
Member Author

@froschdesign thank you for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Essential informations are missing in the introduction
3 participants