Async primitives #85
Async primitives #85
Conversation
| * @param value | ||
| * the grant counter | ||
| */ | ||
| class Semaphore private (private var value: AtomicInteger) extends Async.Source[Unit]: |
There was a problem hiding this comment.
If we want this to be a Source I think it's better to make it a source with a release value (a Source[SemGuard] with a .release method?) or maybe a Resource[Unit]?
There was a problem hiding this comment.
I don't really want it to be a Source. But that's the only thing one can await, so I do need a Source implementation somehow. I could add it as hidden inner object or make Semaphore a trait and have the hidden implementation implement the Source, but both add (allocation/method lookup) overhead.
The SemGuard idea looks nice, but then I would want the Semaphore again to implement it as well, just returning this from the Source.
Using a Semaphore as a Resource is a good idea, but maybe not as the default interface.. ?
…urce.both and all
This PR contains primitives for synchronization and concurrency management:
Resourceto wrap allocation/cleanup of (currently mostly computation) resources in different layers of safetySemaphore, because it's usefulAdditionally, the specification of
Async.awaitin light of locking Sources, that care about there result being used (like Semaphores which the consumer might want to reset on cancellation), was clarified and implemented. Now, cancellation will be ignored if it happens after a listener lock acquire that leads to completion. Still, cancellation can be requested synchronously without waiting.