"community: Fix GithubFileLoader source code", "docs: Fix GithubFileLoader code sample" #19943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `file_extension` init argument in `GithubFileLoader` does not change its behavior at all.
The `GithubFileLoader` sample code in `docs/docs/integrations/document_loaders/github.ipynb` does not work as it stands, for the default branch of the langchain repository is "master" (not "main").
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XS
|
@baskaryan lgtm pending checks |
ccurme
approved these changes
Aug 22, 2024
| @@ -178,7 +178,6 @@ def url(self) -> str: | |||
| class GithubFileLoader(BaseGitHubLoader, ABC): | |||
| """Load GitHub File""" | |||
|
|
|||
| file_extension: str = ".md" | |||
There was a problem hiding this comment.
this is breaking but I can't find any usage of file_extension
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tiny improvements to the
GithubFileLoaderdocument loader and its code sample, addressing the following issues:file_extensionargument ofGithubFileLoaderdoes not change its behavior at all.GithubFileLoadersample code indocs/docs/integrations/document_loaders/github.ipynbdoes not work as it stands.The respective solutions I propose are the following:
file_extensionargument fromGithubFileLoader.master(not the defaultmain) and renamedocumentsasdocument.