community(sparkllm): Add function call support in Sparkllm chat model. #20607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
liugddx
commented
Apr 18, 2024
liugddx
commented
- Description: Add function call support in Sparkllm chat model. Related documents https://www.xfyun.cn/doc/spark/Web.html#_2-function-call%E8%AF%B4%E6%98%8E
- @baskaryan
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
🔌: fireworks
liugddx
changed the title
baskaryan
reviewed
Apr 19, 2024
|
assigning to @ccurme, we should have standard tests for chat models for tool calling right? |
ccurme
reviewed
Jun 17, 2024
| # If function call only, content is None not empty string | ||
| if message_dict["content"] == "": | ||
| message_dict["content"] = None | ||
| if "tool_calls" in message.additional_kwargs: |
There was a problem hiding this comment.
@liugddx we should read tool calls off of message.tool_calls here, instead of (or with higher priority than) additional_kwargs.
| ] | ||
| prompt = ChatPromptTemplate(messages=prompt_msgs) | ||
|
|
||
| chain = prompt | chat.bind(functions=_FUNCTIONS) |
There was a problem hiding this comment.
suggest implementing bind_tools for consistency with other chat models. see example here:
langchain/libs/partners/mistralai/langchain_mistralai/chat_models.py
Lines 626 to 627 in bd4b68c
ccurme
approved these changes
Aug 29, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.