Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Nebula Chat model #21925

Merged
merged 26 commits into from
Aug 23, 2024
Merged

Conversation

sharmisthasg
Copy link
Contributor

Description: Added support for Nebula Chat model in addition to Nebula Instruct
Dependencies: N/A
Twitter handle: @Symbldotai

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 10:34pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels May 20, 2024
Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you docs to the chat model integrations? https://python.langchain.com/v0.1/docs/integrations/chat/

@sharmisthasg
Copy link
Contributor Author

@eyurtsev I have resolved all your comments barring docs. We do not support tool calling and structured output at this time. Could you please point me to the file where I should note this, for it to appear appropriately in the table?

@baskaryan
Copy link
Collaborator

@eyurtsev I have resolved all your comments barring docs. We do not support tool calling and structured output at this time. Could you please point me to the file where I should note this, for it to appear appropriately in the table?

don't need to add nebula to the table but would be nice to have a separate page for it at docs/docs/integrations/chat/nebula.ipynb, like this for example: https://python.langchain.com/v0.2/docs/integrations/chat/cohere/

@baskaryan baskaryan added the needs documentation PR needs to be updated with documentation label May 20, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 21, 2024
@sharmisthasg
Copy link
Contributor Author

@eyurtsev @baskaryan I have added the documentation. Please let me know if there's anything else required

@baskaryan baskaryan removed the needs documentation PR needs to be updated with documentation label May 21, 2024
@sharmisthasg
Copy link
Contributor Author

Hi @baskaryan is there anything else needed on our end for the final deployment?

@ccurme ccurme added the community Related to langchain-community label Jun 18, 2024
@sharmisthasg
Copy link
Contributor Author

Hi @baskaryan @eyurtsev any update on this deployment? The preview looks good, and I think we haven't had any updates in a month. Please let me know if something is needed on my end

@sharmisthasg
Copy link
Contributor Author

@eyurtsev @baskaryan we have an urgent need for this integration, would be very grateful if this merge can be made at the earliest

@sharmisthasg
Copy link
Contributor Author

@eyurtsev @baskaryan could you please tell us what the blocker is, for the merge?

@ktalamad
Copy link

@eyurtsev @baskaryan @ccurme Folks, could you please let us know if/what blocker there is that needs to be addressed for you to merge this? We have customers blocked on this, and need to get the integration in. Thank you!

@ccurme
Copy link
Collaborator

ccurme commented Jul 18, 2024

eyurtsev baskaryan ccurme Folks, could you please let us know if/what blocker there is that needs to be addressed for you to merge this? We have customers blocked on this, and need to get the integration in. Thank you!

CI is blocked on the following:

Docs not matching template:

Document /home/runner/work/langchain/langchain/docs/docs/integrations/chat/symblai_nebula.ipynb does not match the ChatModel Integration page template. Please see #22296 for instructions on how to correctly format a ChatModel Integration page.

Mypy / typing errors:

langchain_community/chat_models/symblai_nebula.py:35: error: Incompatible types in assignment (expression has type "Union[str, List[Union[str, Dict[Any, Any]]]]", variable has type "str") [assignment]
langchain_community/chat_models/symblai_nebula.py:135: error: Incompatible types in assignment (expression has type "str", variable has type "Dict[str, Any]") [assignment]
langchain_community/chat_models/symblai_nebula.py:172: error: Incompatible types in assignment (expression has type "str", variable has type "Dict[str, Any]") [assignment]
langchain_community/chat_models/symblai_nebula.py:217: error: Incompatible types in assignment (expression has type "str", variable has type "Dict[str, Any]") [assignment]
langchain_community/chat_models/symblai_nebula.py:252: error: Incompatible types in assignment (expression has type "str", variable has type "Dict[str, Any]") [assignment]

auto-merge was automatically disabled July 22, 2024 21:49

Head branch was pushed to by a user without write access

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 23, 2024
@ccurme ccurme enabled auto-merge (squash) August 23, 2024 22:19
@ccurme ccurme merged commit 90439b1 into langchain-ai:master Aug 23, 2024
29 checks passed
@ccurme
Copy link
Collaborator

ccurme commented Aug 23, 2024

@ktalamad @sharmisthasg I got this over but needed to do a small refactor and add ignore a type error. Please take a look and test.

@sharmisthasg
Copy link
Contributor Author

@ccurme thanks for the merge, I was able to test the integration! https://python.langchain.com/v0.2/api_reference/community/chat_models/langchain_community.chat_models.symblai_nebula.ChatNebula.html - this link currently gives a 404, is this something that needs to be added on our end? Is it possible to remove it from the docs while the link is broken?

@ccurme
Copy link
Collaborator

ccurme commented Aug 26, 2024

Hi @sharmisthasg, the link should work now that the API docs have built. The content there is determined by the docstring for ChatNebula. You can submit new PRs if you'd like to edit the content at all (feel free to tag me for review).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants