Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: NeptuneGraph fix #23281

Merged
merged 4 commits into from
Aug 23, 2024
Merged

community: NeptuneGraph fix #23281

merged 4 commits into from
Aug 23, 2024

Conversation

leo-gan
Copy link
Collaborator

@leo-gan leo-gan commented Jun 21, 2024

Issue: the service optional parameter was mentioned but not used.
Fix: added this parameter.

@vercel Vercel
Copy link

vercel bot commented Jun 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 3:23pm

@leo-gan leo-gan requested a review from baskaryan June 21, 2024 20:40
@leo-gan leo-gan marked this pull request as ready for review June 21, 2024 21:02
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. community Related to langchain-community 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Jun 21, 2024
@leo-gan
Copy link
Collaborator Author

leo-gan commented Jul 3, 2024

@baskaryan Any comments? Thanks! 😄

@leo-gan leo-gan requested a review from eyurtsev July 12, 2024 00:55
@leo-gan leo-gan removed the request for review from baskaryan August 1, 2024 21:06
@leo-gan
Copy link
Collaborator Author

leo-gan commented Aug 19, 2024

@ccurme Can you review, please?

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 23, 2024
ccurme
ccurme approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service appears to have been removed by a contributor from AWS in this PR, I don't feel we have context to override that.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 23, 2024
@ccurme ccurme enabled auto-merge (squash) August 23, 2024 15:24
@leo-gan
Copy link
Collaborator Author

leo-gan commented Aug 23, 2024

@ccurme Thanks!

@ccurme ccurme merged commit 8788a34 into langchain-ai:master Aug 23, 2024
27 checks passed
@leo-gan leo-gan deleted the community-neptune_graph-fix branch August 23, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme approved these changes

@eyurtsev eyurtsev Awaiting requested review from eyurtsev

Assignees
No one assigned
Labels
community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leo-gan @ccurme