core: pydantic output parser streaming fix #24415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
efriis
commented
Jul 18, 2024
efriis
commented
Jul 18, 2024
Comment on lines
161
to
186
| def test_pydantic_output_parser_stream() -> None: | ||
| """Test PydanticOutputParser in a streaming sequence.""" | ||
|
|
||
| class Person(BaseModel): | ||
| name: str | ||
| age: int | ||
|
|
||
| def llm(input: Any) -> Iterable[str]: | ||
| yield from [ | ||
| "{", | ||
| '"name": "', | ||
| "King", | ||
| " Louis", | ||
| ' XVI"', | ||
| ', "age": 3', | ||
| "8}", | ||
| ] | ||
|
|
||
| parser = PydanticOutputParser(pydantic_object=Person) | ||
| chain = llm | parser | ||
| assert chain.invoke({}) == Person(name="King Louis XVI", age=38) | ||
| stream_result = list(chain.stream({})) | ||
| assert stream_result == [ | ||
| Person(name="King Louis XVI", age=3), | ||
| Person(name="King Louis XVI", age=38), | ||
| ] |
baskaryan
reviewed
Jul 18, 2024
Comment on lines
183
to
186
| assert stream_result == [ | ||
| Person(name="King Louis XVI", age=3), | ||
| Person(name="King Louis XVI", age=38), | ||
| ] |
There was a problem hiding this comment.
why isn't name streamed
There was a problem hiding this comment.
because before there's any age, it doesn't comply to pydantic schema (requires int age)
ccurme
added
Ɑ: core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.