Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Community][minor]: Added langchain_version while calling discover API #24428

Merged
merged 4 commits into from
Aug 26, 2024
Merged

[Community][minor]: Added langchain_version while calling discover API #24428

merged 4 commits into from
Aug 26, 2024

Conversation

dristysrivastava
Copy link
Contributor

@dristysrivastava dristysrivastava commented Jul 19, 2024 •
edited
Loading

  • Description: Added langchain version while calling discover API during both ingestion and retrieval
  • Issue: NA
  • Dependencies: NA
  • Tests: NA
  • Docs NA

@vercel Vercel
Copy link

vercel bot commented Jul 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 11:27am

@eyurtsev
Copy link
Collaborator

cc @Raj725 could confirm?

@Raj725
Copy link
Contributor

Raj725 commented Jul 23, 2024

cc @Raj725 could confirm?

@eyurtsev These changes are pending internal review. We'll mark this PR as ready once the review is complete. Going forward, we'll ensure internal reviews are done before raising a PR. Thanks!

@dristysrivastava dristysrivastava changed the title [Community]: Added langchain_version while calling discover API [Community][minor]: Added langchain_version while calling discover API Jul 31, 2024
@dristysrivastava dristysrivastava marked this pull request as ready for review July 31, 2024 07:40
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases labels Jul 31, 2024
@dristysrivastava
Copy link
Contributor Author

@eyurtsev Please review

@srics
Copy link
Contributor

srics commented Aug 13, 2024

@eyurtsev we intentionally want to grab langchain_community to better support our install base, as that is the primary pkg with pebblo components. We also grab & show langchain pkg version as well (https://github.com/langchain-ai/langchain/blob/master/libs/community/langchain_community/utilities/pebblo.py#L268). We are good with this change from pebblo maintainers.

Pls review, thx!

@eyurtsev eyurtsev self-assigned this Aug 14, 2024
@ccurme
Copy link
Collaborator

ccurme commented Aug 23, 2024

@dristysrivastava sorry for the delay here. There are some merge conflicts; if you resolve these and ping me I'll review.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 26, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 26, 2024
@dristysrivastava
Copy link
Contributor Author

@dristysrivastava sorry for the delay here. There are some merge conflicts; if you resolve these and ping me I'll review.

@ccurme Resolved the merge conflicts. Please review

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 26, 2024
@ccurme ccurme merged commit 7205057 into langchain-ai:master Aug 26, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raj725 Raj725 Raj725 approved these changes

@ccurme ccurme ccurme approved these changes

@eyurtsev eyurtsev Awaiting requested review from eyurtsev

Assignees

@eyurtsev eyurtsev

Labels
community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dristysrivastava @eyurtsev @Raj725 @srics @ccurme