[experimental]: minor fix to open assistants code #24682
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:S
dosubot
bot
added
the
🤖:nit
| if run.required_action: | ||
| required_tool_call_ids = { | ||
| tc.id for tc in run.required_action.submit_tool_outputs.tool_calls | ||
| } |
There was a problem hiding this comment.
In the case when required_action is None, doesn't that leave required_tool_call_ids unbound, which will result in an error on line 631:
if action.tool_call_id in required_tool_call_idsin the list comprehension?
There was a problem hiding this comment.
You're right. Just added code to fix that error - do you mind adding a test case and I can review and then merge?
libs/experimental/langchain_experimental/llms/ollama_functions.py
Outdated
Show resolved
Hide resolved
dosubot
bot
added
size:XS
|
@bengladwell Do you have time to add the test? I can do later if not. |
|
Thanks @isahers1 - I'm in the weeds on some things at the moment. I was hoping to get to this late in the week. If it would be better to get to this sooner, then yeah, that would be great if you would take it. |
|
@bengladwell Later in the week is fine, am busy with some other stuff rn so will take a look again start of next week. |
dosubot
bot
added
size:S
No description provided.