Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch[Community] Optimize methods in several ChatLoaders #24806

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

ZhangShenao
Copy link
Contributor

There are some static methods in ChatLoaders, try to add @staticmethod decorator for them.

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 2:38pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. community Related to langchain-community 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Jul 30, 2024
@ZhangShenao
Copy link
Contributor Author

@ccurme Please help to review this pr.

@ZhangShenao ZhangShenao closed this Aug 2, 2024
@ZhangShenao ZhangShenao reopened this Aug 2, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 23, 2024
@ccurme ccurme merged commit b38c83f into langchain-ai:master Aug 23, 2024
78 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants