Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ollama: allow base_url, headers, and auth to be passed #25078

Merged
merged 2 commits into from
Aug 5, 2024
Merged

ollama: allow base_url, headers, and auth to be passed #25078

merged 2 commits into from
Aug 5, 2024

Conversation

isahers1
Copy link
Collaborator

@isahers1 isahers1 commented Aug 5, 2024

No description provided.

@efriis efriis added the partner label Aug 5, 2024
@efriis efriis self-assigned this Aug 5, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 10:29pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 5, 2024
@isahers1 isahers1 mentioned this pull request Aug 5, 2024
Closed
5 tasks
@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Aug 5, 2024
efriis
efriis reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creating clients on each request seems a bit heavy - should we instantiate on init instead, or just pass through to e.g. ollama.x functions?

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 5, 2024
@efriis efriis changed the title [partner]: allow base_url, headers, and auth to be passed to ollama ollama: allow base_url, headers, and auth to be passed Aug 5, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 5, 2024
@isahers1 isahers1 merged commit 63ddf0a into master Aug 5, 2024
16 checks passed
@isahers1 isahers1 deleted the isaac/ollamafixes branch August 5, 2024 22:39
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
@isahers1 @olgamurraft
ollama: allow base_url, headers, and auth to be passed (langchain-ai#…
113c540 
…25078)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

Assignees

@efriis efriis

Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. partner size:L This PR changes 100-499 lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isahers1 @efriis