Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize SparkLLM #25239

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

maang-h
Copy link
Contributor

@maang-h maang-h commented Aug 9, 2024

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 9, 2024
Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 1:22pm

@dosubot dosubot bot added community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases labels Aug 9, 2024
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maang-h, appreciate your contributions here. Would you mind updating this to match the LLM template in the Appendix here? #24803

The LLM template is different from the chat model template. The chat model template uses message objects with roles (e.g., system, human, etc). Although LLM classes accept these messages, the roles are ignored and the contents are cast to string, as described in the docs here. The template deliberately makes this explicit by passing in strings.

@maang-h
Copy link
Contributor Author

maang-h commented Aug 13, 2024

Thanks @maang-h, appreciate your contributions here. Would you mind updating this to match the LLM template in the Appendix here? #24803

The LLM template is different from the chat model template. The chat model template uses message objects with roles (e.g., system, human, etc). Although LLM classes accept these messages, the roles are ignored and the contents are cast to string, as described in the docs here. The template deliberately makes this explicit by passing in strings.

Done!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 13, 2024
@ccurme ccurme merged commit 089f5e6 into langchain-ai:master Aug 13, 2024
43 checks passed
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
- **Description:** Standardize SparkLLM, include:
  - docs, the issue langchain-ai#24803 
  - to support stream
  - update api url
  - model init arg names, the issue langchain-ai#20085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants