Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add neo4j query constructor for self query #25288

Merged
merged 26 commits into from
Aug 30, 2024

Conversation

moyid
Copy link
Contributor

@moyid moyid commented Aug 12, 2024

  • PR title - community: add neo4j query constructor for self query

  • PR message

  • Add tests and docs: If you're adding a new integration, please include

    1. a test for the integration, preferably unit tests that do not rely on network access,
    2. an example notebook showing its use. It lives in docs/docs/integrations directory.
  • Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 12, 2024
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 2:54pm

@dosubot dosubot bot added community Related to langchain-community Ɑ: retriever Related to retriever module 🔌: neo4j Primarily related to Neo4j integrations 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Aug 12, 2024
@moyid
Copy link
Contributor Author

moyid commented Aug 12, 2024

Hi @ccurme,

I’ve made a small contribution to the LangChain community and would appreciate it if you could help approve the workflows.

Thank you for your support!

@baskaryan
Copy link
Collaborator

cc @tomasonjo @jexp

@tomasonjo
Copy link
Contributor

Thanks for your PR... can you please fix notebook as it has import error and can you leave all the outputs, so that people know what to expect.

I'll try it out later!

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 29, 2024
@moyid
Copy link
Contributor Author

moyid commented Aug 30, 2024

@tomasonjo thanks for taking an initial look! I have fixed the notebook, it's working now!

Copy link
Contributor

@tomasonjo tomasonjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomasonjo
Copy link
Contributor

Btw... i think file 'libs/community/file::memory:?cache=shared' should be deleted

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 30, 2024
@ccurme ccurme enabled auto-merge (squash) August 30, 2024 14:37
@ccurme ccurme merged commit 6377185 into langchain-ai:master Aug 30, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: neo4j Primarily related to Neo4j integrations Ɑ: retriever Related to retriever module size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants