partners: Use simsimd types #25299
Merged
partners: Use simsimd types #25299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
Ɑ: vector store
cbornet
force-pushed
the
simsimd-types
branch
2 times, most recently
from
887c384
to
5902b34
Compare
cbornet
commented
Aug 16, 2024
| @@ -77,7 +77,7 @@ def invoke_cosine_similarity_top_k_score_threshold( | |||
| expected_scores = [1.0, 0.93419873, 0.87038828, 0.83743579] | |||
| actual_idxs, actual_scores = cosine_similarity_top_k(X, Y, score_threshold=0.8) | |||
| assert actual_idxs == expected_idxs | |||
| assert np.allclose(expected_scores, actual_scores) | |||
| assert np.allclose(expected_scores, actual_scores, rtol=1.0e-3) | |||
There was a problem hiding this comment.
simsimd 5 is faster at the cost of a little precision: ashvardanian/SimSIMD#153
ccurme
approved these changes
Aug 23, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simsimd package now has types