Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Refactor PebbloSafeLoader #25582

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

Raj725
Copy link
Contributor

@Raj725 Raj725 commented Aug 20, 2024

Refactor PebbloSafeLoader

  • Created APIWrapper and moved API logic into it.
  • Moved helper functions to the utility file.
  • Created smaller functions and methods for better readability.
  • Properly read environment variables.
  • Removed unused code.

Issue: NA
Dependencies: NA
tests: Updated

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 5:16am

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) 🤖:refactor A large refactor of a feature(s) or restructuring of many files labels Aug 20, 2024
@Raj725
Copy link
Contributor Author

Raj725 commented Aug 22, 2024

@eyurtsev @ccurme Please review

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 22, 2024
@ccurme ccurme merged commit 1f1679e into langchain-ai:master Aug 22, 2024
27 checks passed
@Raj725 Raj725 deleted the refactor/PebbloSafeLoader branch August 22, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:refactor A large refactor of a feature(s) or restructuring of many files size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants