Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Community][minor]: Updating source path, and file path for SharePoint loader in PebbloSafeLoader #25592

Merged
merged 7 commits into from
Aug 26, 2024
Merged

[Community][minor]: Updating source path, and file path for SharePoint loader in PebbloSafeLoader #25592

merged 7 commits into from
Aug 26, 2024

Conversation

dristysrivastava
Copy link
Contributor

  • Description: Updating source path and file path in Pebblo safe loader for SharePoint apps during loading
  • Issue: NA
  • Dependencies: NA
  • Tests: NA
  • Docs NA

@vercel Vercel
Copy link

vercel bot commented Aug 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 11:29am

@dristysrivastava dristysrivastava changed the title Updating source path and file path in Pebblo safe loader for SharePoi… [Community][minor]: Updating source path, and file path for SharePoint loader in PebbloSafeLoader Aug 20, 2024
@dristysrivastava dristysrivastava marked this pull request as ready for review August 20, 2024 19:07
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) 🤖:improvement Medium size change to existing code to handle new use-cases labels Aug 20, 2024
@hwchase17
Copy link
Contributor

has some merge conflicts, otherwise lgtm

@dristysrivastava dristysrivastava force-pushed the dristy-add-path-for-sharepoint-loader branch from 8941b04 to 11401cb Compare August 26, 2024 07:30
@dristysrivastava dristysrivastava mentioned this pull request Aug 26, 2024
Closed
@dristysrivastava
Copy link
Contributor Author

@hwchase17 Fixed the merge conflicts. Kindly review

ccurme
ccurme approved these changes Aug 26, 2024
View reviewed changes
libs/community/langchain_community/utilities/pebblo.py
docs_with_id: List[IndexedDocument], source_path: str
docs_with_id: List[IndexedDocument],
source_path: str,
loader_details: dict,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a kwarg for backwards compatibility?

libs/community/langchain_community/document_loaders/pebblo.py
doc_metadata["full_path"] = get_full_path(
doc_metadata.get(
"full_path", doc_metadata.get("source", self.source_path)
if self.loader.__class__.__name__ == "SharePointLoader":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does if isinstance(self.loader, SharePointLoader) work here?

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 26, 2024
@ccurme ccurme merged commit fbb4761 into langchain-ai:master Aug 26, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raj725 Raj725 Raj725 approved these changes

@ccurme ccurme ccurme approved these changes

Assignees
No one assigned
Labels
community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dristysrivastava @hwchase17 @Raj725 @ccurme