[community] Support passing extra params for executing functions in UCFunctionToolkit #25652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
harupy
reviewed
Aug 23, 2024
libs/community/langchain_community/tools/databricks/_execution.py
Outdated
Show resolved
Hide resolved
harupy
reviewed
Aug 23, 2024
| raise ValueError( | ||
| "Parameter name conflicts with the reserved argument name for executing " | ||
| f"functions: {EXECUTE_FUNCTION_ARG_NAME}. " | ||
| f"Please rename the parameter {EXECUTE_FUNCTION_ARG_NAME}." |
There was a problem hiding this comment.
Is renaming the parameter the only solution...?
There was a problem hiding this comment.
I think it's really rare for such situation, do we need to support other solutions?
There was a problem hiding this comment.
No, but I just thought renaming a parameter can be challenging sometimes.
There was a problem hiding this comment.
I see, the value EXECUTE_FUNCTION_ARG_NAME is __executor_args__, which is unlikely to confict.
Signed-off-by: Serena Ruan <[email protected]>
Signed-off-by: Serena Ruan <[email protected]>
Signed-off-by: Serena Ruan <[email protected]>
Signed-off-by: Serena Ruan <[email protected]>
Signed-off-by: Serena Ruan <[email protected]>
Signed-off-by: Serena Ruan <[email protected]>
Signed-off-by: Serena Ruan <[email protected]>
|
Hi @baskaryan Do you know why the CI fails to install the dependency? I've added it in the extended_testing_deps.txt file. |
baskaryan
approved these changes
Aug 23, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
Support passing extra params when executing UC functions:
The params should be a dictionary with key EXECUTE_FUNCTION_ARG_NAME, the assumption is that the function itself doesn't use such variable name (starting and ending with double underscores), and if it does we raise Exception.
If invalid params passing to the execute_statement, we raise Exception as well.
Add tests and docs: If you're adding a new integration, please include
docs/docs/integrationsdirectory.Lint and test: Run
make format,make lintandmake testfrom the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.