Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: add retry for session expired exception in neo4j #25660

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

noahmay
Copy link
Contributor

@noahmay noahmay commented Aug 22, 2024

Description: The neo4j driver can raise a SessionExpired error, which is considered a retriable error. If a query fails with a SessionExpired error, this change retries every query once. This change will make the neo4j integration less flaky.
Twitter handle: noahmay_

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 22, 2024
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 1:05pm

@dosubot dosubot bot added community Related to langchain-community Ɑ: vector store Related to vector store module 🔌: neo4j Primarily related to Neo4j integrations 🤖:improvement Medium size change to existing code to handle new use-cases labels Aug 22, 2024
Copy link
Contributor

@jexp jexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 22, 2024
@ccurme ccurme enabled auto-merge (squash) August 22, 2024 12:57
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 22, 2024
@ccurme ccurme merged commit 0091947 into langchain-ai:master Aug 22, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: neo4j Primarily related to Neo4j integrations size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants