Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement[Community] Improve methods in IMessageChatLoader #25746

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Improvement[Community] Improve methods in IMessageChatLoader #25746

merged 2 commits into from
Aug 26, 2024

Conversation

ZhangShenao
Copy link
Contributor

@ZhangShenao ZhangShenao commented Aug 26, 2024 •
edited
Loading

  • Add @staticmethod to static methods in IMessageChatLoader.
  • Format args name.

@vercel Vercel
Copy link

vercel bot commented Aug 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 7:35am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. community Related to langchain-community 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Aug 26, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 26, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 26, 2024
@ccurme ccurme merged commit 44e3e23 into langchain-ai:master Aug 26, 2024
27 checks passed
@ZhangShenao ZhangShenao deleted the improve_chat_loaders branch August 28, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme approved these changes

Assignees
No one assigned
Labels
community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:S This PR changes 10-29 lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZhangShenao @ccurme