Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[minor]: [Pebblo] Fix URL construction in newer Python versions #25747

Merged
merged 1 commit into from
Aug 26, 2024
Merged

community[minor]: [Pebblo] Fix URL construction in newer Python versions #25747

merged 1 commit into from
Aug 26, 2024

Conversation

Raj725
Copy link
Contributor

@Raj725 Raj725 commented Aug 26, 2024

  • PR message: Fix URL construction in newer Python versions
  • Description:
    • Update the URL construction logic to use the .value attribute for Routes enum members.
    • This adjustment resolves an issue where the code worked correctly in Python 3.9 but failed in Python 3.11.
    • Clean up unused routes.
  • Issue: NA
  • Dependencies: NA

@vercel Vercel
Copy link

vercel bot commented Aug 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 8:23am

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. community Related to langchain-community labels Aug 26, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 26, 2024
@ccurme ccurme merged commit 745d1c2 into langchain-ai:master Aug 26, 2024
27 checks passed
@Raj725 Raj725 deleted the Fix/Pebblo/url-construction branch August 26, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme approved these changes

Assignees
No one assigned
Labels
community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Raj725 @ccurme