date_time_parser #25763
Merged
date_time_parser #25763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:S
5 tasks
|
Hello, would you mind adding a test for the new functionality? Thanks. |
dosubot
bot
added
size:M
ccurme
approved these changes
Aug 27, 2024
Comment on lines
+164
to
+169
| except Exception as e: | ||
| # If any other unexpected exception type is raised | ||
| if expected is None: | ||
| assert True # Correctly identified that input was invalid | ||
| else: | ||
| pytest.fail(f"Unhandled exception {e} for input {x}") |
There was a problem hiding this comment.
what other exceptions are we expecting here?
There was a problem hiding this comment.
It could be redundant, but was just worried if something like lark error might go unnoticed silently.
dosubot
bot
added
the
lgtm
ccurme
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
PR title: "langchain: Chains: query_constructor: add date time parser"
PR message:
Add tests and docs: If you're adding a new integration, please include
docs/docs/integrationsdirectory.Lint and test: Run
make format,make lintandmake testfrom the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.