Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: optimize xinference llm import #25809

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

cuiihaoo
Copy link
Contributor

@cuiihaoo cuiihaoo commented Aug 28, 2024

Thank you for contributing to LangChain!

  • PR title: "community: optimize xinference llm import"

  • PR message:

    • Description: from xinferece_client import RESTfulClient when there is no importing xinference.
    • Dependencies: xinferece_client
    • Why do so: the total xinference(pip install xinference[all]) is too heavy for installing, let alone it is useless for langchain user except RESTfulClient. The modification has maintained consistency with the xinference embeddings embeddings/xinference.

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 1:39am

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 28, 2024
@cuiihaoo cuiihaoo changed the title add xinference community: optimize xinference llm import Aug 28, 2024
@dosubot dosubot bot added community Related to langchain-community 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Aug 28, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 29, 2024
@baskaryan baskaryan enabled auto-merge (squash) August 29, 2024 01:38
@baskaryan baskaryan merged commit 3555882 into langchain-ai:master Aug 29, 2024
27 checks passed
@lifejoyforpy
Copy link

if not stall xinferece, will error "Could not import RESTfulClient from xinference. Please install it"
" with pip install xinference." what can i do?

@cuiihaoo
Copy link
Contributor Author

if not stall xinferece, will error "Could not import RESTfulClient from xinference. Please install it" " with pip install xinference." what can i do?

  1. 如果这个pr还没有合并到你当前使用的langchain中,可以按照这个commit进行手动修改
  2. 安装xinference client: pip install xinference_client

@lifejoyforpy
Copy link

lifejoyforpy commented Sep 11, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants